nextcloud / nextcloud/external

Favicon doesn't change related to the selected icon

Open
#198 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement feedback-requested
Dominant language
JavaScript
Stars
132
Forks
43
Avg merge
15m
Merged PRs (30d)
2

Description

Hi

it's not a real Issue for me, just a small wish...

Steps to reproduce
  1. Install app
  2. Set external page with own symbol
  3. Navigate to page
Expected behaviour

Symbol is set for link in appmenu.
On click page opens and favicon is the same as the selected symbol in settings

Actual behaviour

Symbol is set for link in appmenu.
On click page opens and favicon remains the standard-icon

Settings

remains the same on NC17, NC18 and NC19
equal if FreeBSD or Ubuntu 18 or Ubuntu 20

sry for my poor english... hope you understand anyway

Thx !!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the behavior with an external page configured with a custom symbol, then trace the app-menu link and page-loading entry points responsible for the selected icon and favicon. No files or tests are named in the issue, so confirm the relevant implementation and add coverage or verification showing that the opened page uses the selected symbol instead of the standard icon.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.