nextcloud / nextcloud/external
Allow iframe options
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 132
- Forks
- 43
- Avg merge
- 15m
- Merged PRs (30d)
- 2
Description
Problem:
- Create link to a website that needs camera permission
- Permission will not be allowed as the
<iframe>link does not contain theallow=""option.
For now, we've simply manually added it to https://github.com/nextcloud/external/blob/89d01a76290e0db8209b70a80a6fd9417353deee/templates/frame.php#L29
Like https://github.com/nextcloud/external/issues/143
but an option could be to insert a simple checkbox on the params like
'Allow camera and microphone? [x]' that would add allow="camera;microphone" into that line if checked.
I think these two are the most common options.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading templates/frame.php at the referenced iframe line and trace how the external-link parameters are assembled. Add a clear way to request camera and microphone permissions, and verify that the generated iframe includes the corresponding allow attribute when enabled.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- html, php
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100