nextcloud / nextcloud/external
Light and dark icons aren't linked anymore
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 132
- Forks
- 43
- Avg merge
- 15m
- Merged PRs (30d)
- 2
Description
How to use GitHub
- Please use the 👍 reaction to show that you are affected by the same issue.
- Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
- Subscribe to receive notifications on status change and new comments.
Steps to reproduce
- Upload a normal icon and one with -dark in the titele
Expected behaviour
Both icons should be shown as one combined.
Actual behaviour
The icons are separate and can be chosen separate.
On my test server, this worked, but now some are linked and some are not.
Also, the icons that are already in the module, are separated.
Server configuration
External sites version: 8.0.1
Nextcloud version: (see Nextcloud admin page)
33.0.5 AIO
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue on External sites 8.0.1 with a normal icon and an icon whose name includes -dark, then inspect the upload and icon-selection entry points. Done means matching light and dark icons are shown as one combined choice, including icons already in the module, rather than as separate choices.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100