nextcloud / nextcloud/external
Custom Icon as Favicon in NC 34
Open
Nobody has claimed this yet.
0. Needs triage
enhancement
- Dominant language
- JavaScript
- Stars
- 132
- Forks
- 43
- Avg merge
- 15m
- Merged PRs (30d)
- 2
Description
In NC 34 the favicon is set to the icon of the current opened app. For embedded external sites this is always the globe symbol.
I suggest using the selected icon for the external site as favicon instead of the globe for all external sites.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how the external-site app chooses the favicon in Nextcloud 34, then compare that path with where the selected icon for an external site is stored or rendered. Done means embedded external sites use their selected icon as the favicon instead of the globe symbol.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 65/100