nextcloud / nextcloud/end_to_end_encryption

Missing upload failed warning for public drop folder

Open
#847 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

0. Needs triage
Dominant language
PHP
Stars
320
Forks
36
Avg merge
1d 8h
Merged PRs (30d)
81

Description

How to use GitHub
  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.

When something goes wrong while uploading a file to an end-to-end encrypted public drop folder, the user gets no clear error message. The file is just marked by an exclamation mark without further explanation or indication of what an explanation mark means in this context.

Steps to reproduce
  1. Create a public file drop link for an end-to-end encrypted folder.
  2. Try dropping a file that’s way too large.
Expected behaviour

Show an error message telling the user that something has gone wrong.

Actual behaviour

The file is listed just like successfully transferred files except with an exclamation mark instead of a check mark.

Server configuration

Operating system: Linux 5.15.0-130-generic x86_64

Web server: Apache/2.4.62

Database: PostgreSQL 16.6 on x86_64-pc-linux-musl

PHP version: 8.3.14

Nextcloud version: 30.0.4

Updated from an older Nextcloud/ownCloud or fresh install: Updated

Where did you install Nextcloud from: Nextcloud AIO

Signing status:

Signing status
No errors have been found.

List of activated apps:

App list
Enabled:
  - activity: 3.0.0
  - admin_audit: 1.20.0
  - app_api: 4.0.3
  - bruteforcesettings: 3.0.0
  - calendar: 5.0.8
  - cloud_federation_api: 1.13.0
  - comments: 1.20.1
  - contacts: 6.1.2
  - dashboard: 7.10.0
  - dav: 1.31.1
  - deck: 1.14.2
  - end_to_end_encryption: 1.16.1
  - federatedfilesharing: 1.20.0
  - federation: 1.20.0
  - files: 2.2.0
  - files_antivirus: 5.6.1
  - files_downloadlimit: 3.0.0
  - files_external: 1.22.0
  - files_fulltextsearch: 30.0.0
  - files_pdfviewer: 3.0.0
  - files_reminders: 1.3.0
  - files_sharing: 1.22.0
  - files_trashbin: 1.20.1
  - files_versions: 1.23.0
  - fulltextsearch: 30.0.0
  - fulltextsearch_elasticsearch: 30.0.0
  - groupfolders: 18.0.8
  - logreader: 3.0.0
  - lookup_server_connector: 1.18.0
  - nextcloud-aio: 0.7.0
  - nextcloud_announcements: 2.0.0
  - notifications: 3.0.0
  - notify_push: 0.7.0
  - oauth2: 1.18.1
  - password_policy: 2.0.0
  - photos: 3.0.2
  - privacy: 2.0.0
  - provisioning_api: 1.20.0
  - recommendations: 3.0.0
  - related_resources: 1.5.0
  - richdocuments: 8.5.3
  - serverinfo: 2.0.0
  - settings: 1.13.0
  - spreed: 20.1.1
  - support: 2.0.0
  - systemtags: 1.20.0
  - tables: 0.8.2
  - tasks: 0.16.1
  - text: 4.1.0
  - theming: 2.5.0
  - twofactor_backupcodes: 1.19.0
  - twofactor_totp: 12.0.0-dev
  - user_status: 1.10.0
  - viewer: 3.0.0
  - weather_status: 1.10.0
  - webhook_listeners: 1.1.0-dev
  - workflowengine: 2.12.0
Disabled:
  - circles: 30.0.0 (installed 28.0.0-dev)
  - contactsinteraction: 1.11.0 (installed 1.5.0)
  - encryption: 2.18.0 (installed 2.18.0)
  - firstrunwizard: 3.0.0 (installed 2.13.0)
  - sharebymail: 1.20.0 (installed 1.14.0)
  - survey_client: 2.0.0 (installed 1.12.0)
  - suspicious_login: 8.0.0 (installed 6.0.0)
  - twofactor_nextcloud_notification: 4.0.0
  - user_ldap: 1.21.0

Are you using external storage, if yes which one: No

Are you using encryption: Not server-side encryption.

Are you using an external user-backend, if yes which one: No

Image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named in the issue. Reproduce the failure by uploading an oversized file through an end-to-end encrypted public drop folder, then trace the public-drop upload flow; done means failed uploads show a clear error message explaining what went wrong rather than only an exclamation mark.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
security
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.