nextcloud / nextcloud/end_to_end_encryption
Allow to share only to e2e enabled users
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 320
- Forks
- 36
- Avg merge
- 1d 8h
- Merged PRs (30d)
- 81
Description
For our new e2e sharing it would be great that clients can directly query for users that have e2e setup already.
Otherwise users would see all sharees, select one and then get message that e2e is not set up for them and thus sharing is not possible.
route: ocs/v2.php/apps/files_sharing/api/v1/sharees
extra parameter could be: e2e user: yes/no
We have in our e2e app already a way to check if public key exists:
https://github.com/nextcloud/end_to_end_encryption/blob/master/lib/Capabilities.php#L48
So if this is true, then this user can be shown.
It would be great to have this in NC26, as we then can same quite some work on our clients.
If not, please tell us soon, so that we can prepare for it.
Either way, I think this should be done, even after NC26 as this is a way better UX.
@AndyScherzinger (as "team lead")
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the sharees endpoint at ocs/v2.php/apps/files_sharing/api/v1/sharees and review the existing public-key check in end_to_end_encryption's lib/Capabilities.php. Define how the optional e2e user yes/no parameter filters results, then verify that clients receive only users with e2e setup when requested while existing sharee queries still work.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- api, security
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100