nextcloud / nextcloud/end_to_end_encryption
bug: Deleting multiple files from the web fails
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 320
- Forks
- 36
- Avg merge
- 1d 8h
- Merged PRs (30d)
- 81
Description
The web UI tries to lock the folder for every delete operation, this fails if a delete is already ongoing.
We should probably reuse the existing lock token.
We should also store whether a lock is being requested as some requests are failing due to a DB duplicate constraint error.
This is probably an issue for other operations.
Request flow when deleting 5 files simultanously:
500 error:
403 error:
cc @susnux
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files or tests are named. Start by tracing the web UI request flow for simultaneous file deletions and the lock-token handling; reproduce several concurrent deletes and inspect the duplicate-constraint, 500, and 403 failures. Done means multiple files can be deleted concurrently without repeated lock requests or those errors.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- security
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100