nextcloud / nextcloud/documentation

[BITV] 9.4.1.2/9.1 - The navigation menu (tree element) implementation is incorrect. The buttons to open the nodes have been implemented as button elements that are inside links.

Open
#9,746 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

1. to develop accessibility
Dominant language
JavaScript
Stars
628
Forks
2.5k
Avg merge
2d 11h
Merged PRs (30d)
135

Description

This should be changed. The aria-expanded attribute should be used with button elements and not on ul and li elements. For more information, see https://www.w3.org/TR/wai-aria-1.2/#aria-expanded and https://www.w3.org/WAI/ARIA/apg/patterns/treeview/. (1)

  • Fix
  • Backport
df5487b90d1bb75c07396787724516b0
Details

https://report.bitvtest.de/default-en/d63601ac-cb34-4645-8256-66bec78964a0.html#checkpoint-bfbf07e5c3-v9-n1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the navigation menu implementation in the documentation project and compare its tree structure with the linked WAI-ARIA specification and treeview pattern. Verify that aria-expanded is associated with the node-opening buttons rather than ul or li elements, then address the listed Fix and Backport checklist items.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
accessibility, frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.