nextcloud / nextcloud/desktop

Remove network.server from File Provider extensions (Mac App Store)

Open
#9,936 0 comments 0 reactions 1 assignee Claimed by @i2h3 View on GitHub
feature: :inbox_tray: install and update os: :apple: macOS
Dominant language
C++
Stars
3.9k
Forks
1k
Avg merge
1d 17h
Merged PRs (30d)
123

Description

Part of: #9941

## Problem

Both `FileProviderExt.appex` and `FileProviderUIExt.appex` declare `com.apple.security.network.server`. This is confirmed in the release build via `codesign`.

This is unusual for extensions of these types:
- A file-syncing extension normally makes outbound connections only.
- A file-provider **UI** extension (showing action dialogs) has no obvious reason to listen on a port at all.

Apple reviewers will flag any `network.server` entitlement and request justification.

## Affected files

- `shell_integration/MacOSX/FileProviderExt.entitlements.cmake` (line 13)
- `shell_integration/MacOSX/FileProviderUIExt.entitlements.cmake`

## Required change

Audit whether either extension truly listens on a TCP/UDP port. If all traffic is outbound (sync to server), remove `network.server` from both. If the File Provider extension uses it for local XPC or socket communication, replace it with the appropriate entitlement or eliminate the need altogether.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.