nextcloud / nextcloud/desktop

Remove Sparkle auto-updater (Mac App Store)

Open
#9,932 0 comments 0 reactions 1 assignee Claimed by @i2h3 View on GitHub
feature: :inbox_tray: install and update os: :apple: macOS
Dominant language
C++
Stars
3.9k
Forks
1k
Avg merge
1d 21h
Merged PRs (30d)
127

Description

Part of: #9941

## Problem

`SUEnableInstallerLauncherService: true` is set in `Info.plist` and Sparkle is compiled in unconditionally. The Mac App Store handles updates natively; submitting an app that bundles Sparkle will cause automatic rejection.

## Affected files

- `src/gui/updater/sparkleupdater_mac.mm`
- `src/gui/updater/sparkleupdater.h`
- `src/gui/updater/CMakeLists.txt`
- `cmake/modules/FindSparkle.cmake`
- `admin/osx/mac-crafter/Sources/Utils/SparkleRepository.swift`
- `admin/osx/mac-crafter/Sources/Commands/Build.swift`

## Required change

Gate all Sparkle code and the `SUEnableInstallerLauncherService` Info.plist key on `NOT BUILD_FOR_APP_STORE` (see companion CMake issue).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.