nextcloud / nextcloud/desktop

[Bug]: Thumbnails are being requested for folders

Open
#9,811 0 comments 0 reactions 1 assignee Claimed by @camilasan View on GitHub
bug os: :door: Windows
Dominant language
C++
Stars
3.9k
Forks
1k
Avg merge
1d 17h
Merged PRs (30d)
123

Description

### ⚠️ Before submitting, please verify the following: ⚠️

- [x] This is a **bug**, not a question or a configuration issue.
- [x] This issue is **not** already reported on Github (I've searched it).
- [x] Nextcloud Server and Desktop Client are **up to date**. See [Server Maintenance and Release Schedule](https://github.com/nextcloud/server/wiki/Maintenance-and-Release-Schedule) and [Desktop Releases](https://nextcloud.com/install/#install-clients) for supported versions.
- [x] I agree to follow Nextcloud's [Code of Conduct](https://nextcloud.com/contribute/code-of-conduct/)

### Bug description

HTTP GET requests are being made needlessly to "index.php/core/preview" for retrieving thumbnails for **folders**.

### Steps to reproduce

Browse a synched folder via Windows Explorer. Look for HTTP requests made.

### Expected behavior

ThumbnailProvider::GetThumbnail should:

`
SFGAOF attributes = 0;
if (SUCCEEDED(_shellItem->GetAttributes(SFGAO_FOLDER, &attributes)) && (attributes & SFGAO_FOLDER)) {
return E_FAIL;
}
`

### Which files are affected by this bug

None

### Operating system

Windows

### Which version of the operating system you are running.

Windows 11

### Package

Official Linux AppImage

### Nextcloud Server version

Latest

### Nextcloud Desktop Client version

Latest

### Is this bug present after an update or on a fresh install?

Updated from a minor version (ex. 3.16.1 to 3.16.2)

### Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

### Are you using an external user-backend?

- [ ] Default internal user-backend
- [ ] LDAP/ Active Directory
- [ ] SSO - SAML
- [ ] Other

### Nextcloud Server logs

```shell

```

### Additional info

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.