nextcloud / nextcloud/desktop

Translate hardcoded strings in Windows installer

Open
#8,105 0 comments 1 reaction 1 assignee Claimed by @nilsding View on GitHub
1. to develop feature: :inbox_tray: install and update feature: :speaking_head: localization
Dominant language
C++
Stars
3.9k
Forks
1k
Avg merge
1d 17h
Merged PRs (30d)
123

Description

With #8103 the base Windows Installer strings are now translated using the translations provided by WixUI.

However, there are still some strings hard-coded in the MSI: most notably the [features](https://github.com/nextcloud/desktop/blob/master/admin/win/msi/Nextcloud.wxs#L219-L220) and some [custom progress texts](https://github.com/nextcloud/desktop/blob/master/admin/win/msi/Nextcloud.wxs#L136-L138).

Apparently it'll be enough to move these texts to a `.wxl` and pass it to `candle.exe`: https://docs.firegiant.com/wix3/tutorial/user-interface-revisited/dontcha-speak-english/

The base en-us .wxl that comes out of that will need to be added to Transifex as well.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.