nextcloud / nextcloud/desktop

[Bug]: Total loss of files when restoring from recycle bin on MacBook possible

Open
#7,822 2 comments 0 reactions 0 assignees View on GitHub
0. Needs triage bug feature: :arrows_counterclockwise: sync engine
Dominant language
C++
Stars
3.9k
Forks
1k
Avg merge
1d 21h
Merged PRs (30d)
127

Description

### ⚠️ Before submitting, please verify the following: ⚠️

- [x] This is a **bug**, not a question or a configuration issue.
- [x] This issue is **not** already reported on Github (I've searched it).
- [x] Nextcloud Server and Desktop Client are **up to date**. See [Server Maintenance and Release Schedule](https://github.com/nextcloud/server/wiki/Maintenance-and-Release-Schedule) and [Desktop Releases](https://nextcloud.com/install/#install-clients) for supported versions.
- [x] I agree to follow Nextcloud's [Code of Conduct](https://nextcloud.com/contribute/code-of-conduct/)

### Bug description

In a special constellation it is possible to completely loose a lot of files when using the sync client at least on a MacBook, maybe the others behave the same. I accidentally put a folder into the recycle bin, then immediately paused the sync. After I restored everything, I continued the sync. This however deleted the files on the server and on my MacBook. The files aren't in the server's recycle bin neither. I have backups to restore from, but this should not happen. At least there should be a way to restore the files from the server's recycle bin.

### Steps to reproduce

1. Delete a folder on the device.
2. Immediately pause the sync in the desktop client.
3. Restore the folder on the device.
4. Resume sync.

### Expected behavior

The files should at least be available in the recycle bin on the server.

### Which files are affected by this bug

a folder with all kinds of files

### Operating system

macOS

### Which version of the operating system you are running.

macOS Sequoia 15.0.1

### Package

Official macOS 12+ universal pkg

### Nextcloud Server version

30.0.5

### Nextcloud Desktop Client version

3.15.0

### Is this bug present after an update or on a fresh install?

Updated to a major version (ex. 3.3.6 to 3.4.0)

### Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

### Are you using an external user-backend?

- [x] Default internal user-backend
- [ ] LDAP/ Active Directory
- [ ] SSO - SAML
- [ ] Other

### Nextcloud Server logs

```shell

```

### Additional info

_No response_

Contributor guide

Open the contributing guide

Research direction

No source files, tests, or entry points are named. Start by reproducing the delete, pause, restore, and resume sequence with the reported macOS 15.0.1, Desktop Client 3.15.0, and Server 30.0.5 versions, then inspect client and server sync logs; done means restored files are not deleted or remain recoverable in the server recycle bin.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, macos
Domain
desktop
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.