[Bug]: Disabling existing folder sync makes notifications spawn continuously
- Dominant language
- C++
- Stars
- 3.9k
- Forks
- 1k
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 127
Description
### ⚠️ Before submitting, please verify the following: ⚠️
- [X] This is a **bug**, not a question or a configuration issue.
- [X] This issue is **not** already reported on Github (I've searched it).
- [X] Nextcloud Server and Desktop Client are **up to date**. See [Server Maintenance and Release Schedule](https://github.com/nextcloud/server/wiki/Maintenance-and-Release-Schedule) and [Desktop Releases](https://nextcloud.com/install/#install-clients) for supported versions.
- [X] I agree to follow Nextcloud's [Code of Conduct](https://nextcloud.com/contribute/code-of-conduct/)
### Bug description
If you sync a folder to the local machine, then disable the synchronisation, the client keeps on spamming notifications about the fact that the folder exists locally, but that it isn't synchronised. While this can be useful if it happens once, when you start the client, it is actually repeated multiple times every single time the client connects to the network, which very quickly becomes annoying rather than informative.
The message reads as follows: "The folder [folder] was created but was excluded from synchronization previously. Data inside it will not be synchronized."
### Steps to reproduce
1. Sync a remote folder to the local machine
2. Disable syncing without deleting the folder
3. Disconnect and re-connect to the network (e.g. by putting the computer to sleep and then waking it)
### Expected behavior
The notification is only presented once, when the client is started.
### Which files are affected by this bug
A folder.
### Operating system
Linux
### Which version of the operating system you are running.
KDE Neon (based on Ubuntu 22.04)
### Package
Distro package manager
### Nextcloud Server version
29.0.6
### Nextcloud Desktop Client version
3.13.2
### Is this bug present after an update or on a fresh install?
Updated from a minor version (ex. 3.4.2 to 3.4.4)
### Are you using the Nextcloud Server Encryption module?
Encryption is Enabled
### Are you using an external user-backend?
- [ ] Default internal user-backend
- [ ] LDAP/ Active Directory
- [ ] SSO - SAML
- [ ] Other
### Nextcloud Server logs
_No response_
### Additional info
_No response_
Contributor guide
Research direction
No source file, test, or entry point is identified in the issue. Reproduce the problem by disabling an existing folder sync, disconnecting and reconnecting the network, and observing the repeated notification; done means the warning appears only once when the client starts.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100