nextcloud / nextcloud/desktop

[Bug]: Offload writing logs to a secondary thread not to freeze the UI

Open
#7,071 0 comments 2 reactions 0 assignees View on GitHub
0. Needs triage bug feature: :arrows_counterclockwise: sync engine good first issue
Dominant language
C++
Stars
3.9k
Forks
1k
Avg merge
1d 17h
Merged PRs (30d)
123

Description

### ⚠️ Before submitting, please verify the following: ⚠️

- [X] This is a **bug**, not a question or a configuration issue.
- [X] This issue is **not** already reported on Github (I've searched it).
- [X] Nextcloud Server and Desktop Client are **up to date**. See [Server Maintenance and Release Schedule](https://github.com/nextcloud/server/wiki/Maintenance-and-Release-Schedule) and [Desktop Releases](https://nextcloud.com/install/#install-clients) for supported versions.
- [X] I agree to follow Nextcloud's [Code of Conduct](https://nextcloud.com/contribute/code-of-conduct/)

### Bug description

Sometime, the client needs to produce lots of log because there are lots of changes to sync
In such cases, the logs will significantly slow down the main thread responsible for executing the synchronization and handling user interaction with the user interface

### Steps to reproduce

1. Run the desktop client
2. Produce a significant amount of changes via for example rename of folders with lots of files in them (think about a deep hierarchy of folders with many files > 50 000)
3. the client can be kept busy producing logs for several seconds with visible slow down

### Expected behavior

The client would never block handling of user interaction actions.

### Which files are affected by this bug

n/a

### Operating system

Windows

### Which version of the operating system you are running.

Windows 11

### Package

Official Windows MSI

### Nextcloud Server version

30.0.0

### Nextcloud Desktop Client version

3.14.0 rc1

### Is this bug present after an update or on a fresh install?

Fresh desktop client install

### Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

### Are you using an external user-backend?

- [ ] Default internal user-backend
- [ ] LDAP/ Active Directory
- [ ] SSO - SAML
- [ ] Other

### Nextcloud Server logs

_No response_

### Additional info

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.