Change share url to domain url when using local ip
- Dominant language
- C++
- Stars
- 3.9k
- Forks
- 1k
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 127
Description
# Feature description
On my desktop I'm using my local ip (ex. 192.168.0.xx:9000) to connect since I'm dealing with big files in size. This is to prevent lots of upload / download on my internet network. On my phone and iPad I use the domain name since these are used outside of my network, the desktop pc is never going to move and therefore always inside the same network as Nextcloud.
The only problem I'm facing with this is when I'm right clicking a file to share, I'm getting a url like this: https://192.168.0.xx:9000/s/2QTFbciNDQWpGGf instead of https://cloud.mydomain.com/s/2QTFbciNDQWpGGf
So everytime I need to change the beginning of the url to my domain so I can actually share it with people outside of my network.
It would be nice if it would use my domain name instead of my local ip for the share options. This is stored in "overwrite.cli.url" in the config.php or the first in array (0) of "trusted_domains"
Contributor guide
Research direction
Start by locating where the desktop client constructs share URLs and how it obtains server configuration; the issue identifies overwrite.cli.url and trusted_domains as the relevant settings. Compare the local-IP and domain cases, then verify that generated share links consistently use the intended domain without breaking local access.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100