nextcloud / nextcloud/desktop

[Bug]: "Encrypt folder" shouldn't be displayed for Group Folders

Open
#4,632 6 comments 0 reactions 0 assignees View on GitHub
bug feature: :lock: end to end encryption
Dominant language
C++
Stars
3.9k
Forks
1k
Avg merge
1d 21h
Merged PRs (30d)
127

Description

### ⚠️ Before submitting, please verify the following: ⚠️

- [X] This is a **bug**, not a question or a configuration issue.
- [X] This issue is **not** already reported on Github (I've searched it).
- [X] Nextcloud Server and Desktop Client are **up to date**. See [Server Maintenance and Release Schedule](https://github.com/nextcloud/server/wiki/Maintenance-and-Release-Schedule) and [Desktop Releases](https://nextcloud.com/install/#install-clients) for supported versions.
- [X] I agree to follow Nextcloud's [Code of Conduct](https://nextcloud.com/contribute/code-of-conduct/)

### Bug description

When end-to-end encryption is enabled in the server an "Encrypt Folder" option is shown in the Settings Dialog for all the folders.

This is ok for normal folder, but the "Encrypt Folder" option shouldn't be displayed for Group Folders.

I did a couple of tests and it is indeed possible to encrypt the folder resulting in an unexpected situation for all the other users with access to that group folder, that is they are locked out of the group folder.

It should be checked if the same behaviour is observed also for External Storage.

### Steps to reproduce

In the Settings Dialog when selecting a Group Folder, the "Encrypt Folder" option is shown.

### Expected behavior

In the Settings Dialog when selecting a Group Folder, the "Encrypt Folder" option shouldn't be shown

### Which files are affected by this bug

NOT APPLICABLE

### Operating system

Linux

### Which version of the operating system you are running.

Ubuntu 22.04 LTS

### Package

Distro package manager

### Nextcloud Server version

c.nc.com

### Nextcloud Desktop Client version

3.5.1

### Is this bug present after an update or on a fresh install?

Fresh desktop client install

### Are you using the Nextcloud Server Encryption module?

Encryption is Enabled

### Are you using an external user-backend?

- [ ] Default internal user-backend
- [ ] LDAP/ Active Directory
- [X] SSO - SAML
- [X] Other

### Nextcloud Server logs

_No response_

### Additional info

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.