Release X.Y.Z

### :memo: TO DO
- [ ] :warning: checks that the milestone associated with the release has no outstanding pending work to be done
- [ ] :arrow_up: Bump VERSION.cmake to X.Y.Z in the corresponding stable branch
- [ ] :label: Create tag from corresponding stable branch on the commit introducing the version bump
```
$ git checkout stable-X.Y
$ git pull
$ git tag -s -m "Release X.Y.Z" vX.Y.Z
$ git push origin --tags
```
```
git remote add releases git@github.com:nextcloud-releases/desktop.git
git fetch origin vX.Y.Z
git push releases vX.Y.Z
```
- [ ] :label: Create tag from corresponding stable branch in [client-building](https://github.com/nextcloud/client-building).
```
$ git checkout stable-X.Y
$ git pull
$ git tag -s -m "Release X.Y.Z" vX.Y.Z
$ git push origin --tags
```
- :factory: Trigger the builds on brander and wait for them to succeed:
- [ ] :penguin: Linux
- [ ] :apple: Mac OS one client
- [ ] :door: Windows MSI
- :test_tube: Execute the bugfix release test plan for each build:
- [ ] :penguin: Linux
- [ ] update from last release candidate (meaning that you have an existing account configured with the release candidate and use it with the official AppImage)
- [ ] upload/download/check activity/check integration to file browser
- [ ] check cpu usage during sync
- [ ] tray menu interaction
- [ ] test Talk notifications (receive notification, reply to a message)
- [ ] fresh installation
- [ ] configure a new account
- [ ] upload/download/check activity/check integration to file browser
- [ ] check cpu usage during sync
- [ ] tray menu interaction
- [ ] test Talk notifications (receive notification, reply to a message)
- [ ] test important new fixes in this release
- [ ] :apple: Mac OS
⚠️ Check the logs for:
- [ ] *Sharing succeeded*: it needs to be signed similarly to .pkg file and uploaded everywhere.
- [ ] Get the link after the last mention of *Sharing succeeded* to download the delta update file (.tbz) (required for automated upgrade).
- [ ] be careful macOS VFS packages are wrongly named and should follow this pattern: `Nextcloud-x.y.z.pkg`
- [ ] update from last release candidate (meaning that you have an existing account configured with the release candidate and upgrade the installation via installer)
- [ ] upload/download/check activity/check integration to file browser
- [ ] check cpu usage during sync
- [ ] tray menu interaction
- [ ] test Talk notifications (receive notification, reply to a message)
- [ ] fresh installation
- [ ] configure a new account using VFS sync
- [ ] upload/download/check activity/check integration to file browser
- [ ] check cpu usage during sync
- [ ] tray menu interaction
- [ ] test Talk notifications (receive notification, reply to a message)
- [ ] test important new fixes in this release
- [ ] configure a new account using selective sync
- [ ] upload/download/check activity/check integration to file browser
- [ ] check cpu usage during sync
- [ ] tray menu interaction
- [ ] test Talk notifications (receive notification, reply to a message)
- [ ] :door: Windows MSI
- [ ] update from last release candidate (meaning that you have an existing account configured with the release candidate and upgrade the installation via installer)
- [ ] upload/download/check activity/check integration to file browser
- [ ] check cpu usage during sync
- [ ] tray menu interaction
- [ ] test Talk notifications (receive notification, reply to a message)
- [ ] fresh installation
- [ ] configure a new account using VFS sync
- [ ] upload/download/check activity/check integration to file browser
- [ ] check cpu usage during sync
- [ ] tray menu interaction
- [ ] test Talk notifications (receive notification, reply to a message)
- [ ] test important new fixes in this release
- [ ] configure a new account using selective sync
- [ ] upload/download/check activity/check integration to file browser
- [ ] check cpu usage during sync
- [ ] tray menu interaction
- [ ] test Talk notifications (receive notification, reply to a message)
- [ ] :old_key: Sign binaries (`ssh -P 2200` to signing VM, then, `cat how-to-sign`, then `scp -P 2200` to download signatures)
- :book: Create draft pre-release and release notes (click on ```Generate release notes```) at:
- [ ] [nextcloud/desktop/releases](https://github.com/nextcloud/desktop/releases)
`⚠️ Only add the release notes. Do not upload the binaries to nextcloud/desktop/releases.`
- [ ] [nextcloud-releases/desktop/releases](https://github.com/nextcloud-releases/desktop/releases) (copy the changelog from [nextcloud/desktop/releases](https://github.com/nextcloud/desktop/releases))
- :package: Upload binaries to:
- [ ] The draft pre-release at [nextcloud-releases/desktop/releases](https://github.com/nextcloud-releases/desktop/releases)
- [ ] download.nextcloud.com in the user home directory (so still private)
- :rocket: Publish the draft pre-releases created previously at:
- [ ] [nextcloud/desktop/releases](https://github.com/nextcloud/desktop/releases)
`⚠️ No binaries on this release page.`
- [ ] [nextcloud-releases/desktop/releases](https://github.com/nextcloud-releases/desktop/releases)
- [ ] Run the `publish_desktop.sh `script on download.nextcloud.com so that the binaries appear at [download.nextcloud.com/desktop/releases](https://download.nextcloud.com/desktop/releases)
- [ ] :bellhop_bell: Notify Marketing that the release is ready.
- [ ] Ask sysadmin to update the `.htaccess` such that latest alias point toward the new release (for example https://download.nextcloud.com/desktop/releases/Windows/latest)
- [ ] Close the milestone for X.Y.Z (make sure every merged PR is included)
- [ ] Create the milestone for X.Y.(Z+1) (make sure every merged PR is included)
- [ ] :up: Change the values of ```$stableReleaseDate``` and ```$stableVersion``` in the [updater server](https://github.com/nextcloud/client_updater_server/blob/master/config/config.php) config to serve the release.
⚠️ For the **mac update service**: the *sparkle:edSignature* and *length* values are printed right after the last mention of *Sharing succeeded* in the brander build log. Replace the values ```"signature"``` and ```"length"``` under ```'macos'``` in ```'stable'``` with them.
- [ ] :up: Change the [install-clients](https://nextcloud.com/install/#install-clients) page to update the link to the latest release on Nextcloud website (direct modification via wordpress web ui)
- [ ] Ensure that desktop client links work on website and release packages are downloaded fine
- [ ] Also test links on portal and that release packages are downloaded fine