nextcloud / nextcloud/desktop

Coordinated Renames in File Provider

Open
#10,163 1 comment 0 reactions 1 assignee Claimed by @i2h3 View on GitHub
feature: :file_folder: file provider os: :apple: macOS
Dominant language
C++
Stars
3.9k
Forks
1k
Avg merge
1d 17h
Merged PRs (30d)
123

Description

Split from #10135, this is something to investigate on and check how it can be fixed.

> When a folder is renamed on another client and LibreOffice has a file open inside it, saving may create a duplicate folder on the server at the old path. The File Provider extension does not coordinate renames through NSFileCoordinator, so macOS cannot notify open applications of the path change even if they implement NSFilePresenter. A proper fix requires the extension to wrap rename operations in NSFileCoordinator writes.
>
> Our extension calls remoteInterface.move(...) (a WebDAV call) and then updates the local database. It does not go through NSFileCoordinator. So even if LibreOffice correctly registered as an NSFilePresenter, it still would not be notified — because our side isn't coordinating.
>
> Our extension needs to use NSFileCoordinator when renaming items.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.