Deck comment mentions do not trigger notifications (users vs user)
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1.4k
- Forks
- 354
- Avg merge
- 1d 10h
- Merged PRs (30d)
- 43
Description
Describe the bug
Mentions in Deck card comments are parsed correctly, but no notification is created for the mentioned user.
Deck 1.18.4 checks in NotificationHelper::sendMention():
if (($mention['type'] ?? 'users') !== 'users') {
continue;
}
However, Nextcloud returns the mention type user, not users, so normal user mentions are skipped.
To Reproduce
- Create a Deck board and share it with another user, e.g.
testuser. - Create a card.
- Add a comment containing
@testuser mention test. - Log in as
testuser. - No notification is shown.
The comment API correctly recognizes the mention:
"mentions": [
{
"mentionId": "testuser",
"mentionType": "user",
"mentionDisplayName": "Test User"
}
]
Other notifications work correctly:
- sharing a Deck board
- assigning/sharing a Deck card
- mentioning the same user in a regular Nextcloud file comment
Expected behavior
The mentioned user should receive a Nextcloud notification.
Screenshots
Not applicable.
Client details:
- Device: desktop
- Browser: not relevant; reproducible server-side
Server details
Operating system: Ubuntu
Nextcloud version: 34.0.3
Deck version: 1.18.4
Signing status:
No errors before applying the workaround (occ integrity:check-app deck produced no output).
Additional information
Changing
if (($mention['type'] ?? 'users') !== 'users') {
to
if (($mention['type'] ?? null) !== 'user') {
immediately restores Deck mention notifications.
This may have been introduced with the board-access check for mentioned users in PR #7983.
Logs
No relevant errors observed.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at NotificationHelper::sendMention(), where the issue identifies the mention-type check, and compare its expected value with the comment API payload. Verify the change against the Deck comment reproduction using a user mention; done means the mentioned user receives a Nextcloud notification without affecting other notification types.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Active
- Clarity
- Clearly specified
- Newbie friendliness
- 78/100