Notification/Activity "added a description to card" triggered when nothing was changed
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1.4k
- Forks
- 354
- Avg merge
- 1d 10h
- Merged PRs (30d)
- 43
Description
How to use GitHub
- Please use the 👍 reaction to show that you are affected by the same issue.
- Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
- Subscribe to receive notifications on status change and new comments.
Describe the bug
When opening and closing a card, it often times triggers an entry in the Activity App "You have added a description to card ..." - no matter if the description was actually added or changed.
Expected behavior
The activity should only be logged when the description was actually added (so only when it was empty before and not empty after).
When the description was changed (so was not empty before and has really changed after), the Activity should be different: "You have changed the description of card ...".
Nextcloud version: 34
Deck App Version: 1.18.3
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or test is named. Start by tracing the card description update and Activity App logging paths in Deck, then reproduce opening and closing a card with an empty and a non-empty description. Done means unchanged descriptions create no activity, first-time descriptions use “added,” and real changes use “changed.”
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 65/100