nextcloud / nextcloud/deck

Improve visuality of 'Mark as done' button to avoid confusion with 'Save'

Open
#8,256 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.4k
Forks
354
Avg merge
1d 10h
Merged PRs (30d)
43

Description

How to use GitHub
  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Is your feature request related to a problem? Please describe.
I'm setting up Nextcloud for a lot of people that aren't that technically confident. Also, they come from a environment where most things they make, a document, and e-mail, etc, require hitting a 'Save' button to actually save the item.

When the create a deck, many will hit the 'Mark as done' button expecting the card to be saved and closed. I must say, I fell for this one myself the first few times.

Luckily, the button changes so you can revert the marking.

Describe the solution you'd like
I've a few possible ideas:

  • hide the "mark as done" button while creating a new card
  • move the button entirely, the 'Mark as done' action is already available in the dot menu next to the x to close the card.
  • keep the button, but style it differently
  • make it clearer the card is already saved
  • add a 'confirm card' button

Describe alternatives you've considered
Add custom CSS to hide the card.

.modal__card .completed-button {
    display: none !important;
}

Additional context
Running:

  • Deck Version 1.17.4
  • Nextcloud AIO v13.4.1 / Hub 26 Winter (33.0.7)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names the frontend selector .modal__card .completed-button but no source file or test. Start by locating that selector and inspecting the card-creation modal and its Mark as done control. The issue is done when users can distinguish saving a new card from marking it complete; the specific visual or placement change still needs agreement.

Written by the indexing model from the issue text.

Assessment

Tech stack
css, javascript
Domain
design, frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.