Initial sync fails on NC32 - "too many requests"
Open
Nobody has claimed this yet.
0. Needs triage
needs info
- Dominant language
- JavaScript
- Stars
- 1.4k
- Forks
- 354
- Avg merge
- 1d 10h
- Merged PRs (30d)
- 43
Description
How to use GitHub
- Please use the 👍 reaction to show that you are affected by the same issue.
- Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
- Subscribe to receive notifications on status change and new comments.
Describe the bug
Trying to (initially) sync against NC 32 leads to "too many requests". Issue appeared after upgrading NC from 27 to 32. Didn't try syncing with inbetween NC versions.
Syncing against other, older instance still works
To Reproduce
Steps to reproduce the behavior:
- Start NC Deck
- Pick account
- Watch initial sync progress and abort
- See error
Expected behavior
Sync succeeds
App Version: 1.24.5
App Version Code: 1024005
Server App Version: 1.16.3
App Flavor: fdroid
Files App Version Code: 30340190 (com.nextcloud.android.sso.model.FilesAppType@f21e38d)
---
OS Version: 4.19.191(1762592020)
OS API Level: 34
Device: Smartphone
Manufacturer: Bigme
Model (and Product): HiBreak (HiBreak_EEA)
---
com.nextcloud.android.sso.exceptions.NextcloudHttpRequestFailedException: HTTP request failed with HTTP status-code: 429
at it.niedermann.nextcloud.deck.remote.api.RequestHelper$ResponseConsumer.onResponse(RequestHelper.java:86)
at com.nextcloud.android.sso.helper.Retrofit2Helper$1.lambda$enqueue$0(Retrofit2Helper.java:77)
at com.nextcloud.android.sso.helper.Retrofit2Helper$1.$r8$lambda$uMprfkVPCD6lUYcD_5EjkPsM_qs(Unknown Source:0)
at com.nextcloud.android.sso.helper.Retrofit2Helper$1$$ExternalSyntheticLambda0.run(D8$$SyntheticClass:0)
at java.lang.Thread.run(Thread.java:1119)
Caused by: java.lang.RuntimeException: HTTP StatusCode wasn't 2xx:
Got [HTTP 429] for Call [GET [http://localhost//ocs/v2.php/apps/deck/api/v1.0/cards/7811/comments]](http://localhost//ocs/v2.php/apps/deck/api/v1.0/cards/7811/comments%5D) with Message:
[<html><body><h1>429 Too Many Requests</h1>
You have sent too many requests in a given amount of time.
</body></html>
]
at it.niedermann.nextcloud.deck.remote.api.RequestHelper$ResponseConsumer.buildCause(RequestHelper.java:103)
... 5 more
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the failing GET request to /ocs/v2.php/apps/deck/api/v1.0/cards/7811/comments and the referenced RequestHelper.java locations. Reproduce the initial sync against Nextcloud 32, then trace the request sequence around the HTTP 429 response. Done means the initial sync completes successfully without the reported rate-limit failure.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- api, backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100