nextcloud / nextcloud/deck

Deleting a card in a read only board fails but is shown as succeeded

Open
#7,234 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

1. to develop bug
Dominant language
JavaScript
Stars
1.4k
Forks
354
Avg merge
1d 10h
Merged PRs (30d)
43

Description

How to use GitHub
  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Describe the bug
Deleting a card in a read only board fails but is shown as succeeded.

To Reproduce
Steps to reproduce the behavior:

  1. Create a new board with user A
  2. Create a new stack with user A
  3. Creae a card with in stack wih user A
  4. Share the board with user B read only
  5. Delete the card with user B

The request fails with HTTP 403 and a success message is being produced and presented to the user B.

Expected behavior
The request fails with HTTP 403 and an error message is being produced and presented to the user B.

Screenshots

Image

Client details:

  • OS: N/A
  • Browser Firefox
  • Version 142.0.1
  • Device: desktop
Server details

Operating system: Nextcloud AIO v11.7.0

Web server: Nextcloud AIO v11.7.0

Database: Nextcloud AIO v11.7.0

PHP version: Nextcloud AIO v11.7.0

Nextcloud version: Nextcloud AIO v11.7.0

Where did you install Nextcloud from: Nextcloud AIO v11.7.0

Signing status:

No errors have been found.

List of activated apps:

if needed on request

Nextcloud configuration:

if needed on request

Are you using an external user-backend, if yes which one: No

Logs
Nextcloud log (data/nextcloud.log)
No relevant entries
Browser log
See screenshot above.

Uncaught (in promise) 
Object { message: "Request failed with status code 403", name: "AxiosError", code: "ERR_BAD_REQUEST", config: {…}, request: XMLHttpRequest, response: {…}, status: 403, stack: "", … }
vuex.esm.js:542:7
    dispatch vuex.esm.js:542
    (Async: promise callback)
    dispatch vuex.esm.js:519
    dispatch vuex.esm.js:518
    dispatch vuex.esm.js:406
    deleteCard CardMenuEntries.vue:151
    click CardMenuEntries.vue:1
    VueJS 4
    onClick actionText-fFcUPi2g.mjs:77
    handleClick NcActionButton-CuVNJJtW.mjs:143
    VueJS 33

Image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the deleteCard entry point in CardMenuEntries.vue around line 151 and inspect how the failed Axios request is handled, using the browser log as context. Reproduce the read-only board scenario and verify that the HTTP 403 displays an error message instead of a success message.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.