nextcloud / nextcloud/deck

Enhancement: Optimizing events

Open
#7,147 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

1. to develop enhancement
Dominant language
JavaScript
Stars
1.4k
Forks
354
Avg merge
1d 10h
Merged PRs (30d)
43

Description

How to use GitHub
  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Is your feature request related to a problem? Please describe.
I am making a app based on the deck app, and I trying to use the events as they are available within the code. The issue is that they all use the same event which isn't a problem by itself, but they don't give through all the required data. As an example, the biggest that I want to use are the CardUpdatedEvents but when I reorder a card, only one card is passed through to the event which is not even the updated card in the first place.

Describe the solution you'd like
The events should be altered to represented the correct actions by using an action parameter and/or giving every action it's own event class. Besides that, the full and correct data should be passed through to the event.

Describe alternatives you've considered
I tried building on top of the events with if statements, but the before data is missing by a lot of events or pass through incorrect data which halted every solution.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the Deck app's CardUpdatedEvents and the event path used when cards are reordered. Compare the data currently emitted with the complete card and before-state data requested here. Done means actions have distinct event information and consumers receive correct, complete data for each action.

Written by the indexing model from the issue text.

Assessment

Domain
backend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.