Attachments (uploaded from device) deleted from the Deck UI are not deleted from the user's ‘/Deck’ folder
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1.4k
- Forks
- 354
- Avg merge
- 1d 10h
- Merged PRs (30d)
- 43
Description
Files added as attachments to Deck cards (via an upload from the computer...) are stored (like other attachments added from Files) in the ‘/Deck’ folder of the user performing the action.
We found that our ‘/Deck’ folders for each user were abnormally large. We found that when an attachment uploaded from the computer is deleted from a card, it is not deleted from the ‘/Deck’ folder.
As a result, there's a big mess in each user's ‘/Deck’ folder, because among the files that are still in use, there are lots of unused files that take up space for nothing on the user quota, which is annoying for some users who have a reduced quota.
When a file uploaded from a device is deleted, it should also be deleted from the ‘/Deck’ folder. In this way, the folder will be lighter and clearer if you need to interact with it directly.
It seems to occur in all recent Deck version (e.g. Deck for NC 29, 30, 31).
How to use GitHub
- Please use the 👍 reaction to show that you are affected by the same issue.
- Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
- Subscribe to receive notifications on status change and new comments.
Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:
- Go to a card
- Upload attachment file
- Go to files in Deck folder and see the attached file
- Delete file from Deck card
- See in Files in Deck folder that the file is still here
Expected behavior
File should disappear from /Deck in "Files"
Client details:
- OS: Ubuntu Desktop 22.04
- Browser FF 135.0.1
Tested on :
- NC 31.0.0 / Deck 1.15.0
- NC 30.0.6 / Deck 1.14.4
- NC 29.0.12 / Deck 1.13.4
Other details or logs can be provided but IMO, this can be easily reproduced.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue using the listed Deck steps on a supported Nextcloud/Deck version, then trace the attachment deletion flow from the Deck card UI to the user's /Deck folder. Done means a device-uploaded attachment removed from a card also disappears from /Deck, while files still in use remain available.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100