Comment mentions not displayed correctly
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1.4k
- Forks
- 354
- Avg merge
- 1d 10h
- Merged PRs (30d)
- 43
Description
How to use GitHub
- Please use the 👍 reaction to show that you are affected by the same issue.
- Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
- Subscribe to receive notifications on status change and new comments.
Describe the bug
When typing @ to add a mention to a comment to select list is not displayed properly if the list is to long.
To Reproduce
Steps to reproduce the behavior:
- Go to a deck card on a shared board with more than 3 people
- Go to the comments tab
- type @ in the new comment input field
- top of the list hidden
Expected behavior
entire list visible/scrollable/ to the bottom where there is space
Screenshots
in this screenshot alice and admin should also be visible (also rendered in DOM but hidden)
PROBABLE ROOT CAUSE:
Overflow hidden in https://github.com/nextcloud-libraries/nextcloud-vue/blob/25f0661c3d194a55a283e9b8c085e587260bdf49/src/components/NcAppSidebar/NcAppSidebar.vue#L1290
could not yet check if vue-at has an option to display the selection on the bottom
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the mention list from a deck card's comments tab on a shared board with more than three people. Inspect the linked nextcloud-vue NcAppSidebar.vue location around line 1290 and check whether vue-at provides a way to place the list where it is visible or scrollable. Done means the full mention list, including entries currently hidden at the top, can be viewed and selected.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100