Regression: comments on a card are not being synced properly, with consequences for Client Push
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1.4k
- Forks
- 354
- Avg merge
- 1d 10h
- Merged PRs (30d)
- 43
Description
How to use GitHub
- Please use the 👍 reaction to show that you are affected by the same issue.
- Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
- Subscribe to receive notifications on status change and new comments.
Describe the bug
When I add a new comment on a card, the counter on the card is not being updated. In combination with the Client Push app, this results in comments not being updated on other devices until a page reload. Interestingly, if the commenter reloads the page, the content (including comments and the counter on the card) gets updated on all devices.
This is a regression which came with some recent update of NC or Deck.
To Reproduce
Steps to reproduce the behavior:
- Go to a deck
- Click on a card
- Add a comment to the card
Expected behavior
The counter of comments on the card should change (+1).
Actual behavior
The counter doesn't change until a page reload.
Client details:
- OS: Fedora 40
- Browser Chromium and Firefox
- Device: desktop, laptop
Server details
Operating system:
Ubuntu 22.04.4
Web server:
Apache
Database:
MariaDB 10.6.18
PHP version:
8.2.22
Nextcloud version:
29.0.5
Where did you install Nextcloud from:
Signing status:
No errors have been found.
List of activated apps:
- activity: 2.21.1
- admin_audit: 1.19.0
- bruteforcesettings: 2.9.0
- calendar: 4.7.16
- cloud_federation_api: 1.12.0
- comments: 1.19.0
- contacts: 6.0.0
- contactsinteraction: 1.10.0
- dav: 1.30.1
- deck: 1.13.1
- drop_account: 2.6.0
- federatedfilesharing: 1.19.0
- federation: 1.19.0
- files: 2.1.1
- files_downloadlimit: 2.0.0
- files_pdfviewer: 2.10.0
- files_reminders: 1.2.0
- files_sharing: 1.21.0
- files_trashbin: 1.19.0
- files_versions: 1.22.0
- firstrunwizard: 2.18.0
- group_everyone: 0.1.16
- groupfolders: 17.0.2
- logreader: 2.14.0
- lookup_server_connector: 1.17.0
- mail: 3.7.7
- nextcloud_announcements: 1.18.0
- notes: 4.10.1
- notifications: 2.17.0
- notify_push: 0.7.0
- oauth2: 1.17.0
- onlyoffice: 9.3.0
- password_policy: 1.19.0
- photos: 2.5.0
- polls: 7.2.0
- privacy: 1.13.0
- provisioning_api: 1.19.0
- qownnotesapi: 24.4.0
- quota_warning: 1.19.0
- recommendations: 2.1.0
- registration: 2.4.0
- related_resources: 1.4.0
- serverinfo: 1.19.0
- settings: 1.12.0
- sharebymail: 1.19.0
- side_menu: 3.13.1
- support: 1.12.0
- survey_client: 1.17.0
- suspicious_login: 7.0.0
- systemtags: 1.19.0
- tasks: 0.16.1
- text: 3.10.1
- theming: 2.4.0
- twofactor_backupcodes: 1.18.0
- updatenotification: 1.19.1
- user_status: 1.9.0
- viewer: 2.3.0
- weather_status: 1.9.0
- workflowengine: 2.11.0
Nextcloud configuration:
{
"system": {
"passwordsalt": "REMOVED SENSITIVE VALUE",
"secret": "REMOVED SENSITIVE VALUE",
"trusted_domains": [
"REMOVED SENSITIVE VALUE",
"localhost",
"REMOVED SENSITIVE VALUE"
],
"datadirectory": "REMOVED SENSITIVE VALUE",
"dbtype": "mysql",
"version": "29.0.5.1",
"overwrite.cli.url": "https://cloud.schloss-schule.wien/",
"dbname": "REMOVED SENSITIVE VALUE",
"dbhost": "REMOVED SENSITIVE VALUE",
"dbport": "",
"dbtableprefix": "oc_",
"dbuser": "REMOVED SENSITIVE VALUE",
"dbpassword": "REMOVED SENSITIVE VALUE",
"installed": true,
"instanceid": "REMOVED SENSITIVE VALUE",
"mail_smtpmode": "smtp",
"mail_smtpsecure": "tls",
"mail_sendmailmode": "smtp",
"mail_from_address": "REMOVED SENSITIVE VALUE",
"mail_domain": "REMOVED SENSITIVE VALUE",
"mail_smtphost": "REMOVED SENSITIVE VALUE",
"mail_smtpauthtype": "LOGIN",
"simpleSignUpLink.shown": false,
"maintenance": false,
"maintenance_window_start": 1,
"mysql.utf8mb4": true,
"default_language": "de_DE",
"default_locale": "de_AT",
"default_phone_region": "AT",
"app_install_overwrite": [
"auto_mail_accounts",
"whiteboard",
"discoursesso"
],
"theme": "",
"loglevel": 2,
"memcache.local": "\OC\Memcache\Redis",
"memcache.locking": "\OC\Memcache\Redis",
"memcache.distributed": "\OC\Memcache\Redis",
"redis": {
"host": "REMOVED SENSITIVE VALUE",
"port": 6379
},
"updater.release.channel": "stable",
"ldapIgnoreNamingRules": false,
"overwritehost": "cloud.schloss-schule.wien",
"auth.bruteforce.protection.enabled": true,
"app.mail.verify-tls-peer": false,
"encryption.legacy_format_support": false,
"encryption.key_storage_migrated": false,
"mail_smtpauth": 1,
"mail_smtpname": "REMOVED SENSITIVE VALUE",
"mail_smtppassword": "REMOVED SENSITIVE VALUE",
"allow_local_remote_servers": true,
"trusted_proxies": "REMOVED SENSITIVE VALUE"
}
}
Are you using an external user-backend, if yes which one:
No
Nextcloud log (data/nextcloud.log)
Browser log
viewer-main.mjs?v=4ce083d9-28:18309 [WARN] viewer: Some mimes were ignored because they are not enabled in the server previews config Object
log @ viewer-main.mjs?v=4ce083d9-28:18309
listener.js:184 [Deprecation] Listener added for a 'DOMNodeRemoved' mutation event. This event type is deprecated, and will be removed from this browser VERY soon. Usage of this event listener will cause performance issues today, and represents a large risk of imminent site breakage. Consider using MutationObserver instead. See https://chromestatus.com/feature/5083947249172480 for more information.
(anonymous) @ listener.js:184
session-heartbeat.js:103 session heartbeat polling started
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue in a Deck card with the Client Push app enabled: add a comment and observe the card counter and another device before and after a reload. Trace the comment update and card-counter refresh from the Deck browser interface; done means the counter and comment appear on other devices without a page reload.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100