Activity not stored for bigger boards because of long subject
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1.4k
- Forks
- 354
- Avg merge
- 1d 10h
- Merged PRs (30d)
- 43
Description
Describe the bug
In a bigger board with many stacks or a lot of users activities are not stored.
In ActivityManager.php there is a limit (SUBJECT_PARAMS_MAX_LENGTH) of 4000 characters for activity subject parameters.
The problem we are having is, that the subject parameters contains a lot of information about the board ( e.g. all acl enries and all stack names) and therefore the activity is not stored . IMHO the information about the board is too verbose and could be shortened.
To Reproduce
Steps to reproduce the behavior:
- Create a new board (with a long name).
- Create several stacks (with long names).
- Share with several users.
- Create a Card in one stack.
- Move Card to another stack.
- If the names are long enough the activity is not stored.
Expected behavior
An activity should be stored about the moved card.
Server details:
- Tested NC versions: 27.1.5 & 28.0.2
- Tested Deck versions: 1.11.3 & 1.12.2
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in lib/Activity/ActivityManager.php, focusing on SUBJECT_PARAMS_MAX_LENGTH and how activity data for moved cards is assembled. Reproduce the issue with long board, stack, and user names, then verify that moving a card still stores an activity without exceeding the subject-parameter limit.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100