nextcloud / nextcloud/deck

Broken link in description after the attachment is deleted

Open
#518 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

1. to develop enhancement feature: attachments feature: description
Dominant language
JavaScript
Stars
1.4k
Forks
354
Avg merge
1d 10h
Merged PRs (30d)
43

Description

Describe the bug
In the description of a card the link of an inserted attachment is broken, after the attachment is deleted

To Reproduce

  1. Attach a file to a card
  2. Insert the attachment (test_attachment.txt) into description
  3. Delete the attachment
  4. Wait until the attachment is finally deleted and the icon for undelete is disappeared
  5. Open the card and click on the link "???? test_attachment.txt", which refers to (/nextcloud/apps/deck/cards/188/attachment/42)
  6. The nextcloud errorpage "Internal Server Error; The server was unable to complete your request.; If this happens again, ..." is displayed

Expected behavior
In the description is only the text "???? test_attachment.txt" or "???? missing attachment: test_attachment.txt" and no clickable link, which refers to the deleted file

Tested with
0.4.0-beta3

Note
Perhaps the behavior depends on the extension of the deleted file. With textfiles there is a broken link, with images it is just like expected "???? test_attachment.jpg" (without link)


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue from a card description using the attachment URL /nextcloud/apps/deck/cards/188/attachment/42, then inspect how deleted attachments are handled when the description is opened. Compare the text-file behavior with the image behavior; done means a deleted attachment is rendered as non-clickable text rather than producing an internal server error.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
full-stack
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.