nextcloud / nextcloud/deck

Link shares from groupfolder won't work anymore for user B if user A attached those files to a deck

Open
#5,048 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug feature: attachments feature: sharing integration
Dominant language
JavaScript
Stars
1.4k
Forks
354
Avg merge
1d 10h
Merged PRs (30d)
43

Description

Describe the bug

When user A shares a groupfolder as attachment to a deck card, file shares from user B won't work anymore when "reshares" are prohibited by configuration or choice.

To Reproduce
Steps to reproduce the behavior:

  1. As admin go to the admin sharing settings. Disable "reshare" as a default permission.
  2. As user A go to 'deck'
  3. Create a card and attach a groupfolder to this card when reshare permissions are not default / set.
  4. As user B create a link share for a file in this groupfolder . There's no error message and the link is created.
  5. As user B or a not logged in user use the created link. The browser displays a not found error.
  6. As user A remove the attachment from the card. The link can be used again.

Expected behavior
Users, that have share permissions to a groupfolder, should be able to share all files within a groupfolder even if those files are attached to a deck card.

Possibly related to: https://github.com/nextcloud/server/issues/38666

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the failure using the listed admin sharing, Deck attachment, groupfolder, and link-share steps, then compare access before and after removing the attachment. Review the possibly related Nextcloud server issue for context; done means users with groupfolder share permissions can create and use file links while files remain attached to a Deck card.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.