nextcloud / nextcloud/deck

Deck comments with mentions are sent twice to NC Client, three times if there is a reply to a comment with a mention

Open
#4,306 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug feature: activity feature: comments
Dominant language
JavaScript
Stars
1.4k
Forks
354
Avg merge
1d 10h
Merged PRs (30d)
43

Description

Steps to reproduce
  1. Install NC client and log in as userB in one computer and log in as UserB on another with the NC client synced
  2. Activate email reminders every 3h
  3. Create a Deck card as UserA
  4. Share board and cardX with UserB
  5. Make a comment as UserA on the card mentioning @UserB (5th of July)
  6. UserB receives a double notification on his NC client
  7. The day after, UserB replies to UserA's comment containing the mention @UserB (6th of July)
  8. @UserB receives three notifications on his NC client
Expected behaviour

UserB should receive 1 notification in the first case an none in the second.

Actual behavior

UserB gets 2 notifications when he is mentioned and 3 to himself when he replies to a comment when he is mentioned

Server configuration

Operating system: Linux 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64

Web server: Hetzner Storage share

Database: nginx/1.18.0 (fpm-fcgi)

PHP version: 8.0.25

Nextcloud version: (see Nextcloud admin page) 24.0.7

Where did you install Nextcloud from: Hetzner Storage share

Signing status:

Login as admin user into your Nextcloud and access
http://example.com/index.php/settings/integrity/failed 
paste the results here.

List of activated apps:

Enabled:
 - accessibility: 1.10.0
 - activity: 2.16.0
 - breezedark: 24.0.2
 - calendar: 3.5.2
 - circles: 24.0.1
 - cloud_federation_api: 1.7.0
 - comments: 1.14.0
 - contactsinteraction: 1.5.0
 - dashboard: 7.4.0
 - dav: 1.22.0
 - deck: 1.7.3
 - federatedfilesharing: 1.14.0
 - federation: 1.14.0
 - files: 1.19.0
 - files_automatedtagging: 1.14.0
 - files_pdfviewer: 2.5.0
 - files_rightclick: 1.3.0
 - files_sharing: 1.16.2
 - files_trashbin: 1.14.0
 - files_versions: 1.17.0
 - files_videoplayer: 1.13.0
 - firstrunwizard: 2.13.0
 - flow_notifications: 1.4.0
 - groupfolders: 12.0.2
 - jitsi: 0.15.0
 - logreader: 2.9.0
 - lookup_server_connector: 1.12.0
 - nextcloud_announcements: 1.13.0
 - notifications: 2.12.1
 - notify_push: 0.5.0
 - oauth2: 1.12.0
 - password_policy: 1.14.0
 - photos: 1.6.0
 - privacy: 1.8.0
 - provisioning_api: 1.14.0
 - recommendations: 1.3.0
 - serverinfo_hetzner: 1.16.0
 - settings: 1.6.0
 - sharebymail: 1.14.0
 - spreed: 14.0.6
 - support: 1.7.0
 - survey_client: 1.12.0
 - systemtags: 1.14.0
 - text: 3.5.1
 - theming: 1.15.0
 - twofactor_backupcodes: 1.13.0
 - updatenotification: 1.14.0
 - user_status: 1.4.0
 - viewer: 1.8.0
 - weather_status: 1.4.0
 - workflowengine: 2.6.0
Disabled:
 - admin_audit
 - encryption
 - files_external
 - user_ldap

Nextcloud configuration:

{
    "skeletondirectory": "\/var\/www\/html\/themes\/hetzner\/skeleton",
    "simpleSignUpLink.shown": false,
    "memcache.local": "\\OC\\Memcache\\APCu",
    "appstoreurl": "https:\/\/apps.your-storageshare.de",
    "apps_paths": [
        {
            "path": "\/var\/www\/html\/apps",
            "url": "\/apps",
            "writable": false
        },
        {
            "path": "\/var\/www\/html\/custom_apps",
            "url": "\/custom_apps",
            "writable": true
        }
    ],
    "files_external_allow_create_new_local": false,
    "loglevel": 2,
    "log_type": "syslog",
    "updatechecker": false,
    "updater.server.url": "https:\/\/updates.your-storageshare.de",
    "updater.release.channel": "stable",
    "passwordsalt": "***REMOVED SENSITIVE VALUE***",
    "secret": "***REMOVED SENSITIVE VALUE***",
    "trusted_domains": [
        "nx30641.your-storageshare.de",
        "nextcloud.balthasarspeyr.org"
    ],
    "datadirectory": "***REMOVED SENSITIVE VALUE***",
    "dbtype": "mysql",
    "version": "24.0.7.1",
    "overwrite.cli.url": "https:\/\/nx30641.your-storageshare.de",
    "dbname": "***REMOVED SENSITIVE VALUE***",
    "dbhost": "***REMOVED SENSITIVE VALUE***",
    "dbport": "",
    "dbtableprefix": "oc_",
    "mysql.utf8mb4": true,
    "dbuser": "***REMOVED SENSITIVE VALUE***",
    "dbpassword": "***REMOVED SENSITIVE VALUE***",
    "installed": true,
    "instanceid": "***REMOVED SENSITIVE VALUE***",
    "default_language": "en",
    "default_locale": "en",
    "default_phone_region": "US",
    "mail_smtpmode": "smtp",
    "mail_smtpauthtype": "LOGIN",
    "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
    "mail_from_address": "***REMOVED SENSITIVE VALUE***",
    "mail_domain": "***REMOVED SENSITIVE VALUE***",
    "syslog_tag": "nextcloud-nx30641",
    "upgrade.disable-web": true,
    "theme": "hetzner",
    "templatedirectory": "\/var\/www\/html\/core\/skeleton\/Templates\/",
    "enabledPreviewProviders": [
        "OC\\Preview\\PNG",
        "OC\\Preview\\JPEG",
        "OC\\Preview\\GIF",
        "OC\\Preview\\BMP",
        "OC\\Preview\\XBitmap",
        "OC\\Preview\\MP3",
        "OC\\Preview\\TXT",
        "OC\\Preview\\MarkDown",
        "OC\\Preview\\OpenDocument",
        "OC\\Preview\\Krita",
        "OC\\Preview\\HEIC"
    ],
    "redis": {
        "host": "***REMOVED SENSITIVE VALUE***",
        "port": "6379",
        "timeout": "1.5",
        "dbindex": "0"
    },
    "filelocking.enabled": true,
    "memcache.locking": "\\OC\\Memcache\\Redis",
    "memcache.distributed": "\\OC\\Memcache\\Redis",
    "maintenance": false
}

Are you using an external user-backend, if yes which one: LDAP/ActiveDirectory/Webdav/...

Client configuration

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/107.0.0.0 Safari/537.36

Operating system: Mac mini m1 Monterey

Logs
Nextcloud log (data/nextcloud.log)
Insert your Nextcloud log here
Browser log
Insert your browser log here, this could for example include:

a) The javascript console log
b) The network log 
c) ...

Additional info
Screenshots - NC client main window and Settings.

Now that I am watching the double notifications, it may be the fact that a comment with a mention and the same as created comment are not recognized as pertaining to the same comment and thus two notifications are sent (but maybe it is what is espected?). But the second screenshot, where the three notifications are sent is more surprising because they are identical messages.

Below I also paste my present notifications settings, in case it helps.

Two notifications
Schermata 2022-12-09 alle 16 20 32

Three notifications
The tree are identical this time and the case is the one above
UserB replies to UserA's comment containing the mention @userb and gets three notifications from himself.
Schermata 2022-12-09 alle 16 25 55

Notifications settings
Schermata 2022-12-09 alle 16 22 05

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the numbered Deck comment and mention reproduction steps, using the listed Nextcloud 24.0.7 and Deck 1.7.3 setup as context. No source file, test, or entry point is named, so trace how a mentioned comment and its reply generate notifications; done means one notification for the first mention and none for the self-reply case.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.