Own deck card actions not handled correctly
Open
Nobody has claimed this yet.
1. to develop
bug
feature: activity
feature: notification
- Dominant language
- JavaScript
- Stars
- 1.4k
- Forks
- 354
- Avg merge
- 1d 10h
- Merged PRs (30d)
- 43
Description
$this->userId is mostlikely not set in background jobs and when sending activity emails.
Should use \OCP\Activity\IManager>getCurrentUserId() instead.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in lib/Activity/DeckProvider.php at line 89 and inspect how the user ID is obtained for own deck card actions. Check the background-job and activity-email paths mentioned in the issue. Done means those paths use the current activity user ID reliably instead of an unset $this->userId.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 58/100