nextcloud / nextcloud/deck

Timeline-Error Comments on Cards by Guests

Open
#3,729 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feature: activity feature: comments question
Dominant language
JavaScript
Stars
1.4k
Forks
354
Avg merge
1d 10h
Merged PRs (30d)
43

Description

Hey,

First of all, thank you very much for your effort: Nextcloud Deck is a great work relief for me!

I sometimes use Deck as a ticket system. I therefore set comments directly in the database. So far, this all works well too. Only in the "Timeline" an error message is displayed if I specify a non-existent user in the activity in the "subjectparams" under "author":

Rich subject or parameter for "{user} hat die Karte {card} kommentiert" is malformed

This is due to the following code line:
https://github.com/nextcloud/deck/blob/15c5170195d243b42612375771ea174e714358cb/lib/Activity/DeckProvider.php#L103

I have removed the condition and now the "Timeline" works as desired.

Is there a reason for this condition? If not, please remove this condition so that I don't have to adjust the code line again after each update.

Thanks in advance!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at lib/Activity/DeckProvider.php around line 103 and inspect why the author parameter is rejected when the referenced user does not exist. Verify the Timeline behavior for a comment whose activity subjectparams names a non-existent author; done means it no longer displays the malformed rich-subject error.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.