Performance issue?
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1.4k
- Forks
- 354
- Avg merge
- 1d 10h
- Merged PRs (30d)
- 43
Description
How to use GitHub
- Please use the 👍 reaction to show that you are affected by the same issue.
- Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
- Subscribe to receive notifications on status change and new comments.
Describe the bug
I've got a lot of such messages when retrieving stacks of a board:
"app":"deck","method":"GET","url":"/index.php/apps/deck/stacks/10","message":"Controller OCA\\Deck\\Controller\\StackController::index created 140 QueryBuilder objects, please check if they are created inside a loop by accident.","userAgent":"Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:94.0) Gecko/20100101 Firefox/94.0","version":"22.2.0.2"}
"app":"deck","method":"GET","url":"/index.php/apps/deck/stacks/10","message":"Controller OCA\\Deck\\Controller\\StackController::index executed 140 queries.","userAgent":"Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:94.0) Gecko/20100101 Firefox/94.0","version":"22.2.0.2"}
Is it normal?
To Reproduce
Steps to reproduce the behavior:
- Go to Deck's web interface and open a board with 10+ cards
Expected behavior
In an ideal world such messages should not appear imho. At least messages recommand to check if the QueryObjects aren't created inside a loop by accident. So, I think it's worth creating an issue.
Screenshots
No screenshots, everything seems to be working ok appart from these messages
Client details:
- OS: [e.g. iOS]
- Browser [e.g. chrome, safari]
- Version [e.g. 22]
- Device: [e.g. iPhone6, desktop]
Server details
Operating system:
Web server:
Database:
PHP version:
Nextcloud version: (see Nextcloud admin page)
Where did you install Nextcloud from:
Signing status:
Login as admin user into your Nextcloud and access
http://example.com/index.php/settings/integrity/failed
paste the results here.
List of activated apps:
If you have access to your command line run e.g.:
sudo -u www-data php occ app:list
from within your Nextcloud installation folder
Nextcloud configuration:
If you have access to your command line run e.g.:
sudo -u www-data php occ config:list system
from within your Nextcloud installation folder
or
Insert your config.php content here
Make sure to remove all sensitive content such as passwords. (e.g. database password, passwordsalt, secret, smtp password, …)
Are you using an external user-backend, if yes which one: LDAP/ActiveDirectory/Webdav/...
Logs
Nextcloud log (data/nextcloud.log)
Insert your Nextcloud log here
Browser log
Insert your browser log here, this could for example include:
a) The javascript console log
b) The network log
c) ...
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at OCA\Deck\Controller\StackController::index for GET /index.php/apps/deck/stacks/10 and reproduce the request on a board with 10+ cards. Check whether the reported QueryBuilder and query counts are expected, then document or address the cause so opening the board no longer produces unjustified performance warnings.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend, database, performance
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100