"update description" activity misattributed
Open
Nobody has claimed this yet.
bug
feature: activity
feature: description
- Dominant language
- JavaScript
- Stars
- 1.4k
- Forks
- 354
- Avg merge
- 1d 10h
- Merged PRs (30d)
- 43
Description
How to use GitHub
- Please use the 👍 reaction to show that you are affected by the same issue.
- Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
- Subscribe to receive notifications on status change and new comments.
Describe the bug
When you create a description on a card that was last edited by someone else, the description update is misattributed to them.
Looks like https://github.com/nextcloud/deck/blob/bbf0394df217ff5b2def5901e56023e22710e219/lib/Service/CardService.php#L316 should be $this->currentUser instead.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in lib/Service/CardService.php around line 316, where the card description update is recorded. Verify the actor used when a card was last edited by someone else, then confirm that the activity is attributed to the user creating the description.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100