Deck 1.3.0: File-attachments not deletable via API
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1.4k
- Forks
- 354
- Avg merge
- 1d 10h
- Merged PRs (30d)
- 43
Description
Update
It's just missing in the docs that an additional optional query param called type must be passed in order to delete file attachments. type can have deck_file (default) or file as value. The latter is required for file attachments which are available since Deck 1.3.0
Original issue
How to use GitHub
- Please use the 👍 reaction to show that you are affected by the same issue.
- Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
- Subscribe to receive notifications on status change and new comments.
Describe the bug
The Android Deck App has issues deleting attachments of type file. We call the good old documented delete path, but the API refuses to do anything.
According to the documentation, we call the API as follows:
@DELETE("v1.0/boards/{boardId}/stacks/{stackId}/cards/{cardId}/attachments/{attachmentId}")
Observable<Void> deleteAttachment(@Path("boardId") long boardId, @Path("stackId") long stackId, @Path("cardId") long cardId, @Path("attachmentId") long attachmentId);
To Reproduce
Steps to reproduce the behavior:
- In Android Deck app, open a card with
file-type attachment(s) - Go to the attachments tab
- long-press on a
file-type attachment - select delete
- see that it doesn't work
Expected behavior
Attachment should be deleted.
Nextcloud version: 21
Deck version: 1.3.0
CC: @stefan-niedermann
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open the linked API documentation for deleting attachments and compare it with the issue's described DELETE path. Document the optional type query parameter, including the deck_file and file values and when file is required. Done means the documentation explains how to delete file-type attachments.
Written by the indexing model from the issue text.
Assessment
- Domain
- api, documentation
- Issue type
- Documentation
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100