Modal view closes on mouse-up event
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1.4k
- Forks
- 354
- Avg merge
- 1d 10h
- Merged PRs (30d)
- 43
Description
Describe the bug
I edited a description in the modal view. When selecting text, the modal 'unexpectedly' closed. This happened because I dragged my mouse cursor outside the modal before releasing the mouse button.
To Reproduce
Steps to reproduce the behavior:
- Go to the modal view.
- Click somewhere inside the modal view, hold the mouse-button.
- Drag mouse outside modal view and release mouse-button
- The modal closes.
Expected behavior
The modal should only close on a mouse-down, or a mouse-down+up event. Not an isolated mouse-up event.
Client details:
- OS: Browser.
- Browser: recent versions of chromium, firefox, Edge(chrome)-dev, vivaldi. epiphany.
- Deck 1.2.3 Nextcloud 20.0.4.
- Device: Desktop (Manjaro Linux).
It's a minor inconvenience.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue in the modal view: press inside it, drag outside, and release. Trace the modal's mouse event handling and ensure an isolated mouse-up outside does not close it; verify the expected close behavior with the reproduction steps in a recent browser.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100