nextcloud / nextcloud/deck

Domain name missing from links to attachments in notifications (email)

Open
#2,593 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug feature: activity feature: attachments feature: notification needs info
Dominant language
JavaScript
Stars
1.4k
Forks
354
Avg merge
1d 10h
Merged PRs (30d)
43

Description

Describe the bug
2020-11-20_10-31-58

Error in the links with attachments during notifications sent by e-mail.
The domain name is not included, I have:
/index.php/apps/deck/cards/1220/attachment/4
On the other hand the link on the card is just https://domaine.com/index.php/apps/deck/#/board/57/card/1220
2020-11-20_10-38-35

Expected behavior
The attachment link should be complete with the domain mon.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing a notification email containing an attachment, then trace where the attachment URL is assembled. Compare the generated link with the card link shown in the issue. Done means attachment links in notification emails include the instance domain and remain usable.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.