nextcloud / nextcloud/deck

Attachments can not be deleted

Open
#2,486 5 comments 8 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

1. to develop bug feature: attachments good first issue
Dominant language
JavaScript
Stars
1.4k
Forks
354
Avg merge
1d 10h
Merged PRs (30d)
43

Description

How to use GitHub
  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Describe the bug

If I want to delete an attachment, I can click on the delete button.
However, that never deletes the attachment but keeps it around. You can still restore it and it will still show in the list of attachments to insert into the description.

To Reproduce
Steps to reproduce the behavior:

  1. Upload Attachment
  2. Click on delete
  3. Attachment will be flagged as deleted
  4. But Attachment wont go away

Expected behavior

If the attachment is deleted, it should not be visible anymore in the list of attachments to insert.

Furthermore there should be a method to actually delete attachments. Maybe have a second button to finally delete the attachment if wanted.

Screenshots
Attachment is "deleted"
attchment_deleted

but still selectable:
attachment_insert

NC 19.0.4 / Deck 1.1.2

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

First reproduce the listed upload, delete, and insert-selection steps in the attachment interface. Trace the attachment delete flow and the list of attachments available for insertion; done means deleted attachments are no longer selectable, with the intended permanent-deletion behavior clarified and covered by the relevant checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.