nextcloud / nextcloud/deck

Stop editing Description after I hit Escape key

Open
#1,982 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

1. to develop enhancement feature: description
Dominant language
JavaScript
Stars
1.4k
Forks
354
Avg merge
1d 10h
Merged PRs (30d)
43

Description

Is your feature request related to a problem? Please describe.
Keyboard controls are always time saving shortcuts, especially to exit the most used editing

Describe the solution you'd like
GIVEN I am editing the Description
WHEN I hit the Escape key
THEN the editing is closed (like with I click on the eye icon)

Describe alternatives you've considered
Contemplate the eye icon and think about the Life, the Universe and Everything :)

Additional context
Capture d’écran de 2020-06-04 18-24-42
Look, the eye is watching you! :)

Thanks

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the Description editor and the existing eye-icon action that closes editing. Compare the Escape-key behavior with that action, then verify that pressing Escape closes the editor without changing the description and run the relevant frontend tests if available.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.