Refactor board activites to filter by board id
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1.4k
- Forks
- 354
- Avg merge
- 1d 10h
- Merged PRs (30d)
- 43
Description
The activity app onyl allows fetching by object_type and object_id
Currently all card activities are fetched and filtered by board in the frontend.
A possible way to improve this would be to also create an activity for the object_type board for all card actions.
Probably also needs some adjustments on the parameters that get replaced:
https://github.com/nextcloud/deck/blob/f18accd9c44fa82dee49e62ed3695f8b151000f8/lib/Activity/DeckProvider.php#L121
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked activity app entry point in APIv2.php and compare it with Deck's ActivityManager.php, especially the references around lines 61-62 and 304. Then inspect DeckProvider.php around line 121 for parameter replacement. Done means board activities can be fetched by board ID without frontend filtering, with the related activity parameters adjusted consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- api, backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100