nextcloud / nextcloud/cookbook
URL import from lidl-kochen.de is not possible for all recipes
Nobody has claimed this yet.
- Dominant language
- HTML
- Stars
- 641
- Forks
- 113
- Avg merge
- 21h 31m
- Merged PRs (30d)
- 26
Description
Failing website:
for example:
https://www.lidl-kochen.de/rezeptwelt/caponata-mit-pasta-kapern-und-rosinen-134094
https://www.lidl-kochen.de/rezeptwelt/ueberbackener-blumenkohl-144768
Checking if valid metadata are present:
Yes, I check the source code of the website and found metadata.
Cookbook version: 0.11.5
Problem description (if applicable):
The page could not be imported. The error message in nextcloud log shows: trim(): Argument #1 ($string) must be of type string, array given in file '/nextcloud/apps/cookbook/lib/Helper/Filter/JSON/FixToolsFilter.php' line 60
Some URLs from lidl-kochen.de are working like https://www.lidl-kochen.de/rezeptwelt/grundrezept-pesto-rosso-246136 .
I see no difference in the metadata in schema.org.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in nextcloud/apps/cookbook/lib/Helper/Filter/JSON/FixToolsFilter.php at line 60 and compare the metadata from the two failing lidl-kochen.de URLs with the working pesto URL. Check how the schema.org metadata reaches the filter and reproduce the trim() type error. Done means the failing recipes import successfully without regressing the working URL.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100