nextcloud / nextcloud/contacts

Do not suggest props that are not compatible with the version of the vcard

Open
#631 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

1. to develop medium
Dominant language
JavaScript
Stars
642
Forks
220
Avg merge
14h 39m
Merged PRs (30d)
51

Description

On the add new property, we should not allow the addition of properties that are not allowed on the vcard rfc.

There is an issue regarding the allowed data on the ical.js: https://github.com/mozilla-comm/ical.js/issues/363

https://github.com/mozilla-comm/ical.js/blob/d26b19fa5adb4d3d6e03bff6c6e4c0705c12ab11/lib/ical/design.js#L873


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the “add new property” flow and compare its suggestions with the vCard rules referenced in ical.js design.js around line 873. Read the linked ical.js issue about allowed data and determine how the vCard version affects compatibility. Done means incompatible properties are no longer suggested or addable.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.