nextcloud / nextcloud/contacts

Split ReadOnlyContactDetails into mountContactDetails and fetchContactDetails

Open
#4,826 0 comments 0 reactions 1 assignee View on GitHub

Nobody has claimed this yet.

1. to develop enhancement
Dominant language
JavaScript
Stars
642
Forks
220
Avg merge
14h 39m
Merged PRs (30d)
51

Description

Is your feature request related to a problem? Please describe.

Christoph and I discussed the ReadOnlyContactDetails component.

The issue we ran into in Mail is that using the component multiple times triggers unnecessary extra requests, since each instance fetches the list of address books again.

We’re mitigating this with https://github.com/nextcloud/contacts/pull/4716,https://github.com/nextcloud/mail/pull/11912, and https://github.com/nextcloud/contacts/pull/4794, but we should still look into creating a new version that separates fetching the contact data from rendering the component once we have time.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.