nextcloud / nextcloud/contacts

Importing a vcf file will skip the NOTE field content after the first comma

Open
#3,721 8 comments 0 reactions 1 assignee View on GitHub

@hamza221 is already working on this.

Since Dec 19, 2023.

2. developing bug feature: contacts feature: import
Dominant language
JavaScript
Stars
642
Forks
220
Avg merge
14h 39m
Merged PRs (30d)
51

Description

Describe the bug

When trying to import an addressbook, if a contact contains some "NOTE" data containing a comma, the field is only imported up to the first comma.

Steps to reproduce

Given the following vcf file

BEGIN:VCARD
VERSION:3.0
N:Test;Alice;;;
FN:Alice Test
TEL;TYPE=CELL:redacted
NOTE:Some note without comma
END:VCARD
BEGIN:VCARD
VERSION:3.0
N:Test;Bob;;;
FN:Bob Test
TEL;TYPE=CELL:redacted
NOTE:Some note, with comma
END:VCARD
  1. Go to contacts app
  2. Click on Import contacts button
  3. Select previously saved vcf file
  4. Import it
Expected behavior

When looking at Alice Test contact, the Note field should read "Some note without comma"

When looking at Bob Test contact, the Note field should read "Some note, with comma"

Actual behavior

When looking at Alice Test contact, the Note field reads "Some note without comma" ✅

When looking at Bob Test contact, the Note field reads "Some note" ❗

Contact version

5.4.2 on NC 27.1.4

Operating system

Debian 5.10

PHP engine version

Other

Web server

Nginx

Database

MariaDB

Additional info

PHP 8.2.13

Installed as Nextcloud App for YunoHost https://github.com/YunoHost-Apps/nextcloud_ynh/

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.