nextcloud / nextcloud/contacts
Hide "Exclude contact from birthday calendar" for read-only contacts
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 642
- Forks
- 220
- Avg merge
- 14h 39m
- Merged PRs (30d)
- 51
Description
Describe the bug
Read only contacts can't be edited. Excluding from birthday calendar requires a change to the vcard.
Steps to reproduce
- Run Nextcloud 27
- Open a contact in the system address book
- Open the header actions
Expected behavior
I don't see Exclude contact from birthday calendar
Actual behavior
I see Exclude contact from birthday calendar and run into https://github.com/nextcloud/contacts/issues/3408
Contact version
5.3
Operating system
No response
PHP engine version
None
Web server
None
Database
None
Additional info
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce this in Nextcloud 27 by opening a contact from the system address book and viewing the header actions. Start by tracing the implementation of “Exclude contact from birthday calendar” and how read-only contacts are identified. Done means the action is absent for read-only contacts while remaining available for editable contacts, without triggering the issue described in contacts#3408.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100