nextcloud / nextcloud/contacts
Hide *Delete* action for read-only address books
Open
Nobody has claimed this yet.
2. developing
bug
feature: contacts
- Dominant language
- JavaScript
- Stars
- 642
- Forks
- 220
- Avg merge
- 14h 39m
- Merged PRs (30d)
- 51
Description
Describe the bug
Some address books can't be deleted
Steps to reproduce
- Run Nextcloud server master
- Open the contacts app
- Open the contacts settings
- Open the actions menu of the Accounts address book
Expected behavior
No delete action
Actual behavior
I see a delete action
Contact version
5.3.0 Beta 2
Operating system
No response
PHP engine version
None
Web server
None
Database
None
Additional info
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue by opening the Contacts app, then the contacts settings and the Accounts address book actions menu. Trace the frontend code that builds this menu and its read-only state; done means read-only address books no longer show a Delete action while deletable address books retain it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100