nextcloud / nextcloud/contacts

Extend contacts menu to show system address book users too

Open
#3,341 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

0. Needs triage enhancement
Dominant language
JavaScript
Stars
642
Forks
220
Avg merge
14h 39m
Merged PRs (30d)
51

Description

Is your feature request related to a problem? Please describe.

With https://github.com/nextcloud/contacts/pull/173 and https://github.com/nextcloud/server/pull/3233 we removed the system address book contacts from the contacts menu.

With https://github.com/nextcloud/server/issues/37797 we expose the system address book in contacts, adding them back makes sense (while still respecting share enumeration settings).

cc @jancborchardt

Describe the solution you'd like

Remove the filter in \OC\ContactsManager::search and \OCA\Contacts\ContactsMenu\Providers\DetailsProvider::process that remove the system contacts from showing up.

Add share enumeration filtering to the \OC\ContactsManager::search function to limit the available contacts to what is allowed by admins.

Also remove guest users (same as in the system address book code from https://github.com/nextcloud/server/issues/37797)

Describe alternatives you've considered

Leaving the contacts menu as is

Additional context

Follow up to https://github.com/nextcloud/server/issues/19575

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading \OC\ContactsManager::search and \OCA\Contacts\ContactsMenu\Providers\DetailsProvider::process, along with the referenced system address book behavior. Trace how share enumeration settings and guest users are handled, then verify that permitted system address book users appear in the contacts menu while excluded users do not.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.