nextcloud / nextcloud/contacts
Ask if EntityPicker modal can be closed
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 642
- Forks
- 220
- Avg merge
- 14h 39m
- Merged PRs (30d)
- 51
Description
Is your feature request related to a problem? Please describe.
It is frustrating when I accidently click somewhere outside of Modal (when adding users to circle), and all the users I picked are lost.
Describe the solution you'd like
I propose to ask (maybe another Modal) user if he is sure he wants to close the modal, and warn him that picked users will not be added to circle if he proceeds. Maybe it (Modal) should pop up only when closing Modal with more than 5 users picked in it.
Describe alternatives you've considered
Close Modal only with 'Cancel' button
Additional context
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the EntityPicker modal and its close or dismiss handling, then review how selected users are retained or discarded. Done means accidental dismissal warns about losing selected users, while the intended cancel behavior remains clear and the proposed threshold is resolved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100